Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SceneInstanceReady #9313

Merged
merged 2 commits into from Aug 15, 2023
Merged

Add SceneInstanceReady #9313

merged 2 commits into from Aug 15, 2023

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Jul 31, 2023

Objective

Closes #9115, replaces #9117.

Solution

Emit event when scene is ready.

Changelog

Added

  • SceneInstanceReady event when scene becomes ready.

@Shatur Shatur mentioned this pull request Jul 31, 2023
Closed
@alice-i-cecile alice-i-cecile added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Scenes Serialized ECS data stored on the disk labels Jul 31, 2023
alice-i-cecile
alice-i-cecile requested changes Jul 31, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution better: one quick improvement though :)

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 11, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 15, 2023
Merged via the queue into bevyengine:main with commit d60b715 Aug 15, 2023
21 checks passed
Shatur added a commit to projectharmonia/bevy that referenced this pull request Aug 19, 2023
@Shatur
Add SceneInstanceReady (bevyengine#9313)
b9e6d15 
# Objective

Closes bevyengine#9115, replaces bevyengine#9117.

## Solution

Emit event when scene is ready.

---

## Changelog

### Added

- `SceneInstanceReady` event when scene becomes ready.
@cart cart mentioned this pull request Oct 13, 2023
Merged
43 tasks
@daxpedda daxpedda mentioned this pull request Dec 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hymm hymm hymm approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf Awaiting requested review from mockersf

Assignees
No one assigned
Labels
A-Scenes Serialized ECS data stored on the disk C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit event when scene is ready
3 participants
@Shatur @hymm @alice-i-cecile