Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary doc string #9481

Merged
merged 2 commits into from Aug 21, 2023
Merged

Remove unnecessary doc string #9481

merged 2 commits into from Aug 21, 2023

Conversation

hate
Copy link
Contributor

@hate hate commented Aug 18, 2023

Objective

Solution

  • Remove the doc string mentioning the position of a NodeBundle, since the doc string for the style component already explains this ability.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-UI Graphical user interfaces, styles, layouts, and widgets labels Aug 18, 2023
@github-actions
Copy link
Contributor

Example alien_cake_addict failed to run, please try running it locally and check the result.

ickshonpe
ickshonpe suggested changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@ickshonpe ickshonpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. The same line should be removed from AtlasImageBundle too.

@github-actions
Copy link
Contributor

Example alien_cake_addict failed to run, please try running it locally and check the result.

@rparrett
Copy link
Contributor

rparrett commented Aug 18, 2023 •
edited

Could you please check the other UI bundles? I recall there being at least one other instance of this comment on a node field.

It would be great to get the docs for node to be uniform across all the UI bundles.

edit: Oops, sorry. Was beaten to the punch.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 19, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 21, 2023
Merged via the queue into bevyengine:main with commit ee0f2a7 Aug 21, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rparrett rparrett rparrett approved these changes

@ickshonpe ickshonpe ickshonpe approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up doc string in NodeBundle
4 participants
@hate @rparrett @ickshonpe @alice-i-cecile