Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some missing pub in ui_node #9529

Merged
merged 1 commit into from Aug 22, 2023
Merged

Add some missing pub in ui_node #9529

merged 1 commit into from Aug 22, 2023

Conversation

IceSentry
Copy link
Contributor

Objective

  • A few of the const DEFAULT properties of the grid feature are not marked as pub. This is an issue because it means you can't have a const Style declaration anymore. Most of the existing properties are already pub.

Solution

  • add the missing pub

@IceSentry IceSentry added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change labels Aug 22, 2023
@alice-i-cecile alice-i-cecile added C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Aug 22, 2023
@mockersf mockersf added this pull request to the merge queue Aug 22, 2023
Merged via the queue into bevyengine:main with commit 546f7fc Aug 22, 2023
25 checks passed
@IceSentry IceSentry deleted the pub-default-ui-node branch August 25, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@ickshonpe ickshonpe ickshonpe approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IceSentry @alice-i-cecile @mockersf @ickshonpe