Manual "Reflect Value" AssetPath impl to fix dynamic linking #9752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
added
C-Bug
mdickopp
reviewed
Sep 11, 2023
Co-authored-by: Martin Dickopp <martin@zero-based.org>
alice-i-cecile
approved these changes
Sep 13, 2023
mdickopp
approved these changes
Sep 13, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…ine#9752) # Objective Fix bevyengine#9747 ## Solution Linkers don't like what we're doing with CowArc (I'm guessing it has something to do with `?Sized`). Weirdly the `Reflect` derive on `AssetPath` doesn't fail, despite `CowArc` not implementing `Reflect`. To resolve this, we manually implement "reflect value" for `AssetPath<'static>`. It sadly cannot use `impl_reflect_value` because that macro doesn't support static lifetimes. --------- Co-authored-by: Martin Dickopp <martin@zero-based.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #9747
Solution
Linkers don't like what we're doing with CowArc (I'm guessing it has something to do with
?Sized). Weirdly theReflectderive onAssetPathdoesn't fail, despiteCowArcnot implementingReflect.To resolve this, we manually implement "reflect value" for
AssetPath<'static>. It sadly cannot useimpl_reflect_valuebecause that macro doesn't support static lifetimes.