Per-Object Motion Blur

[aevyrie]

Screen.Recording.2023-12-12.at.1.42.15.AM.mp4

Objective

• Adds per-object motion blur to the core 3d pipeline. This is a common effect used in games and other simulations.
• Partially resolves Request add Soft shadow and motion blur function #4710

Solution

• This is a post-process effect that uses the depth and motion vector buffers to estimate per-object motion blur. The implementation is combined from knowledge from multiple papers and articles. The approach itself, and the shader are quite simple. Most of the effort was in wiring up the bevy rendering plumbing, and properly specializing for HDR and MSAA.
• To work with MSAA, the MULTISAMPLED_SHADING wgpu capability is required. I've extracted this code from Add handling for more naga capabilities #9000. This is because the prepass buffers are multisampled, and require accessing with textureLoad as opposed to the widely compatible textureSample.
• Added an example to demonstrate the effect of motion blur parameters.

Future Improvements

• While this approach does have limitations, it's one of the most commonly used, and is much better than camera motion blur, which does not consider object velocity. For example, this implementation allows a dolly to track an object, and that object will remain unblurred while the background is blurred. The biggest issue with this implementation is that blur is constrained to the boundaries of objects which results in hard edges. There are solutions to this by either dilating the object or the motion vector buffer, or by taking a different approach such as https://casual-effects.com/research/McGuire2012Blur/index.html
• I'm using a noise PRNG function to jitter samples. This could be replaced with a blue noise texture lookup or similar, however after playing with the parameters, it gives quite nice results with 4 samples, and is significantly better than the artifacts generated when not jittering.

---

Changelog

• Added: per-object motion blur. This can be enabled and configured by adding the MotionBlurBundle to a camera entity.

[github-actions]

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

[aevyrie]

CI is failing on check bans for some reason. 🤷

[JMS55]

Needs rebasing, please

[JMS55]

Shader could avoid some branches, use a better noise (IGN/STBN), and could experiment with some established surface comparison heuristics (plane distance, normals) (commonly used in denoising), but it works well enough and I don't want to block on further, possibly futile, experimentation. I'm happy merging it as-is.

[aevyrie]

Can anyone recommend a way to profile performance? I'm dubious to make perf changes without being able to meaningfully measure perf.

[JMS55]

Make sure you have a reproducible exact frame setup, and then run it through Nvidia's NSight GPU Frame Profiler, or AMD's equivalent (Radeon Graphics Analyzer iirc). You'll get per-pass timings, as well as statistics on shader occupancy, per-line stalls and timings, etc.

[aevyrie]

I'm working on Metal. 😧

[JMS55]

I really wouldn't worry about the perf, lets just leave it as-is.

[github-actions]

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

[github-actions]

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

[pcwalton]

I didn't look at this too closely yet but it looks fine to me, none of these nits should be considered blocking.

[pcwalton]

This looks good to me, just a couple of nits.

[alice-i-cecile]

I'm comfortable with the code quality here, and this is a useful standard rendering feature. Merging :)