Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore time channel error #9981

Merged
merged 1 commit into from Oct 1, 2023
Merged

ignore time channel error #9981

merged 1 commit into from Oct 1, 2023

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Sep 30, 2023

Objective

Changelog

  • ignore disconnected errors from the time channel.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Time Involves time keeping and reporting labels Sep 30, 2023
@hymm hymm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 30, 2023
@james7132 james7132 added this pull request to the merge queue Oct 1, 2023
Merged via the queue into bevyengine:main with commit 1d7577f Oct 1, 2023
24 checks passed
@hymm hymm deleted the ignore-time-channel-panic branch October 3, 2023 16:08
regnarock pushed a commit to regnarock/bevy that referenced this pull request Oct 13, 2023
@hymm @regnarock
ignore time channel error (bevyengine#9981)
3518e4a 
# Objective

- sometimes when bevy shuts down on certain machines the render thread
tries to send the time after the main world has been dropped.
- fixes an error mentioned in a reply in
bevyengine#9543

---

## Changelog

- ignore disconnected errors from the time channel.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@hymm
ignore time channel error (bevyengine#9981)
4e9758c 
# Objective

- sometimes when bevy shuts down on certain machines the render thread
tries to send the time after the main world has been dropped.
- fixes an error mentioned in a reply in
bevyengine#9543

---

## Changelog

- ignore disconnected errors from the time channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@JoJoJet JoJoJet JoJoJet approved these changes

Assignees
No one assigned
Labels
A-Time Involves time keeping and reporting C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hymm @james7132 @alice-i-cecile @JoJoJet