Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Profile > removing relations does not work (could not add a working Route in LegacyLoader) #81

Closed
thisismeonmounteverest opened this issue Nov 15, 2018 · 8 comments
Assignees
Projects

Comments

@thisismeonmounteverest
Copy link
Contributor

Route isn't the issue but the redirect afterwards.

Couldn't find a good way for that either yet.

@thisismeonmounteverest thisismeonmounteverest created this issue from a note in Code (In progress) Nov 15, 2018
@thisismeonmounteverest thisismeonmounteverest moved this from In progress to Current Backlog in Code Nov 15, 2018
@thisismeonmounteverest thisismeonmounteverest moved this from Current Backlog to In progress in Code Nov 15, 2018
@thisismeonmounteverest thisismeonmounteverest moved this from In progress to Current Backlog in Code Nov 15, 2018
@ghost
Copy link

ghost commented Jan 1, 2019

Hi, could you describe how to exactly to reproduce (step by step) this issue and how exactly this should work? I'd like to fix it :)

@thisismeonmounteverest
Copy link
Contributor Author

Login as member-101. Go to your profile and click the edit link on the 'Family and relations'.

@ghost
Copy link

ghost commented Jan 1, 2019

Ok, and what is expected result? How should it works?

@ghost
Copy link

ghost commented Jan 1, 2019

I reproduce this bug, see screenshot (I don't sure that it is :))

screenshot from 2019-01-01 14-53-01

Or maybe I still have a wrong setup of my dev machine :)

@amnesiac84 amnesiac84 moved this from Current Backlog to In progress in Code Jan 2, 2019
@thisismeonmounteverest
Copy link
Contributor Author

That's not the expected problem (that is caused by using PHP 7.3 and fixed now).

There are two members with whom member-101 has a relation. The deletion works but the redirect should be to the same page but ends on the landing page (/).

@ghost
Copy link

ghost commented Jan 2, 2019

I see, now I can reproduce this bug

screenshot from 2019-01-02 19-31-02

As you wrote, redirection is to main page, what is the proper redirection (for this specific case from this screenshot)?

@thisismeonmounteverest
Copy link
Contributor Author

The correct redirect would be to the same page so that the user can review the other relations and decide if others need to be removed as well.

@thisismeonmounteverest thisismeonmounteverest assigned ghost and thisismeonmounteverest and unassigned ghost Jan 4, 2019
@thisismeonmounteverest thisismeonmounteverest moved this from In progress to Current Backlog in Code Jan 5, 2019
@thisismeonmounteverest thisismeonmounteverest moved this from Current Backlog to Ready for testing in Code Jan 5, 2019
@amnesiac84 amnesiac84 moved this from Ready for testing to Problem in Code Jan 13, 2019
@amnesiac84
Copy link
Contributor

Routes to https://alpha.bewelcome.org//editmyprofile (double // is returning a 404)

@thisismeonmounteverest thisismeonmounteverest moved this from Problem to Current Backlog in Code Jan 14, 2019
@thisismeonmounteverest thisismeonmounteverest moved this from Current Backlog to Ready for testing in Code Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Code
  
Ready for testing
Development

No branches or pull requests

2 participants