Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some weapon types misuse size vs collisionSize #1480

Open
sprunk opened this issue Apr 28, 2024 · 0 comments
Open

Some weapon types misuse size vs collisionSize #1480

sprunk opened this issue Apr 28, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@sprunk
Copy link
Collaborator

sprunk commented Apr 28, 2024

size is for visuals and collisionSize is for setting the physical radius.


This one should use drawRadius (i.e. size) and not radius (i.e. collisionSize). There shouldn't be an arbitrary x1.3 multiplier either.

This one should not multiply by size, keep it to collisionSize.

SetRadiusAndHeight(weaponDef->size * weaponDef->collisionSize, 0.0f);

This one should not increase the physical radius, just the drawRadius, and not multiply by collisionSize again.

radius = radius + weaponDef->sizeGrowth;
sqRadius = radius * radius;
drawRadius = radius * weaponDef->collisionSize;

@sprunk sprunk added the good first issue Good for newcomers label Apr 28, 2024
IcarusRTS added a commit to IcarusRTS/spring that referenced this issue May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant