Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the token on the linkedin button #302

Merged
merged 1 commit into from May 14, 2020
Merged

Replace the token on the linkedin button #302

merged 1 commit into from May 14, 2020

Conversation

rshipp
Copy link
Contributor

@rshipp rshipp commented May 14, 2020 •
edited

task: https://app.asana.com/0/1170776727341290/1173524622792756/f

Basically just copied this piece from higher up and moved it outside the .bz-ajax-replace selector. The code comment explains why.

Screen Shot 2020-05-14 at 1 55 20 PM

sadleb
sadleb approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@sadleb sadleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I’ll take care of enabling the service in the portal and configuring our LinkedIn dev api to allow this new domain name to access it.

@rshipp rshipp merged commit c979a81 into staging May 14, 2020
@rshipp rshipp deleted the nce-linkedin-button branch May 14, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadleb sadleb sadleb approved these changes

@jessouyangbraven jessouyangbraven Awaiting requested review from jessouyangbraven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rshipp @sadleb