Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 10.x Compatibility #32

Merged
merged 1 commit into from Nov 20, 2023

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l10-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^9.5.10. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-comments.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "beyondcode/laravel-comments": "dev-l10-compatibility",
    }
}

Finally, run: composer update

@grantholle
Copy link

Hey BeyondCode team, could someone review this and get it merged?

@yusufkaracaburun
Copy link

When can this be merged?

@Cyrille37
Copy link

Hi there. Nice & useful package, thanks @mpociot :-)

What's about merging this PR (to avoid too many forks) ?

@Rattone
Copy link

Rattone commented Nov 17, 2023

@mpociot @sschlein are you going to consider this?

@Rattone
Copy link

Rattone commented Nov 20, 2023

Thank you @mechelon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants