Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json for Laravel 9 #99

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Update composer.json for Laravel 9 #99

merged 1 commit into from
Feb 23, 2022

Conversation

colinmackinlay
Copy link
Contributor

Hope this helps - composer packages updated - lets see if CI tests pass too

Hope this helps - composer packages updated - lets see if CI tests pass too
@colinmackinlay
Copy link
Contributor Author

@mpociot - I think this is ok, it would be great if you could check and merge if ok. Even if you don't tag a release we could still pull it in using dev:master and run our Laravel 9 upgrades :)

@clementmas
Copy link
Contributor

I agree with @colinmackinlay. Ideally this package needs to cleaned up to remove support for old versions. But meanwhile if @mpociot can get at least merge this PR we could use it with Laravel 9. That's the only package preventing me from upgrading.

@sschlein sschlein merged commit 3f96076 into beyondcode:master Feb 23, 2022
@colinmackinlay colinmackinlay deleted the patch-1 branch February 23, 2022 10:42
@sschlein
Copy link
Member

I just did a yolo merge into dev:master based on your comments and put this on our list if packages that need more love soon! Without further testing, I don't want to tag a new release today.

@colinmackinlay
Copy link
Contributor Author

I just did a yolo merge into dev:master based on your comments and put this on our list if packages that need more love soon! Without further testing, I don't want to tag a new release today.

Thank you - that seems very sensible. We can now choose to require dev:master at our own risk. If we encounter any issues I'll report back, maybe even with a PR to fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants