[2.x] Fix unsubscribeFromAllChannels leaving stale connections

[simonbuehler]

the each-> call silently ran only until the first channel was a unable to unsubscribe the connection
leading to users on other channels seeming randomly not getting unsubscribed,
stale connections, a frustrated dev and a fishy smell all over the place.

after some serious hours of debugging and searching for this sneaky bug
the websocket-world is now a better place ;)

please merge ASAP, this is relevant for basically all setups that use more than one channel!
should fix e.g. #654, #657, #623 and propably #228,

edit:
fixed description

[codecov-io]

Codecov Report

Merging #708 (6b6197f) into master (efb3aa8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #708      +/-   ##
============================================
+ Coverage     90.71%   90.73%   +0.01%     
  Complexity        2        2              
============================================
  Files            60       60              
  Lines          1691     1694       +3     
============================================
+ Hits           1534     1537       +3     
  Misses          157      157              

Impacted Files	Coverage Δ	Complexity Δ
src/ChannelManagers/LocalChannelManager.php	97.98% <100.00%> (+0.04%)	0.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb3aa8...6b6197f. Read the comment docs.

[troy-whitespark]

Maybe not the right place for this, but if you don't mind sharing why exactly did this fix the issue?

I might be blind but aren't the changes just syntactic? What about higher order messages in collections was causing this to fail?

Thanks!

[simonbuehler]

This is a good question but I didn't went down the rabbithole, i was too happy this finally worked.
Indeed would be interesting why this failed, maybe promise-related black magic?

[simonbuehler]

@troy-whitespark @rennokki

if i understand it correctly the each gets a break when the closure returns false https://github.com/laravel/framework/blob/12b3d57c6f150e1b8def4535c347638113c22664/src/Illuminate/Collections/Traits/EnumeratesValues.php#L231

when unsubscription of a channel is not successfull

laravel-websockets/src/Channels/Channel.php

Lines 111 to 113 in efb3aa8

	if (! $this->hasConnection($connection)) {
	return false;
	}

so thats the issue i guess - what do you think?

[i-rocky]

I'm having the same issue and this PR does solve the problem.
@simonbuehler you're right. Returning false from Channel::unsubscribe() breaking the loop.

[simonbuehler]

pls merge