Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

[1.x] Update pusher/pusher-php-server versions #955

Merged
merged 6 commits into from
Mar 3, 2022

Conversation

joecampo
Copy link
Contributor

@joecampo joecampo commented Feb 23, 2022

Hi there,

This PR updates the versions for pusher-php-server to match the master branch. In Laravel 9 I believe you need to use version ^7.0.

  • This will make the 1.x version useable in Laravel 9.
  • All of these changes are already reflected in the master branch

Fixes #951
Fixes #956
Fixes #945
Fixes #943

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #955 (5b81c2b) into 1.x (345d57f) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x     #955      +/-   ##
============================================
+ Coverage     53.93%   53.99%   +0.05%     
============================================
  Files            50       50              
  Lines           927      926       -1     
============================================
  Hits            500      500              
+ Misses          427      426       -1     
Impacted Files Coverage Δ
src/HttpApi/Controllers/Controller.php 69.64% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345d57f...5b81c2b. Read the comment docs.

@PaolaRuby
Copy link

Needs others changes
#895
#830
#908

@erikn69
Copy link
Contributor

erikn69 commented Feb 24, 2022

for laravel 9.x maybe try composer require "beyondcode/laravel-websockets:dev-master"

"pusher/pusher-php-server": "^3.0|^4.0|^5.0|^6.0|^7.0",

@joecampo joecampo changed the title Update pusher/pusher-php-server versions [1.x] Update pusher/pusher-php-server versions Feb 24, 2022
@joecampo
Copy link
Contributor Author

@PaolaRuby Thanks! I've implemented those fixes for tests as applicable to the 1.x branch & added support for GuzzleHttp/Psr7 ^2.0 – Composer no longer downgrades that dependency and everything seems to be in working order.

@erikn69
Copy link
Contributor

erikn69 commented Feb 24, 2022

GuzzleHttp/Psr7 must be 1.7|2.0, 1.5,1.6 are incompatible witn 2.0

"guzzlehttp/psr7": "^1.7|^2.0",

@joecampo
Copy link
Contributor Author

@erikn69 fixed!

@mpociot mpociot merged commit f0649b6 into beyondcode:1.x Mar 3, 2022
@mpociot
Copy link
Member

mpociot commented Mar 3, 2022

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants