Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian no longer ships ack-grep #122

Closed
etanot opened this issue Sep 25, 2020 · 4 comments · Fixed by #123
Closed

Debian no longer ships ack-grep #122

etanot opened this issue Sep 25, 2020 · 4 comments · Fixed by #123

Comments

@etanot
Copy link
Contributor

etanot commented Sep 25, 2020 •
edited

Since Debian 10 (Buster), Debian is longer shipping ack-grep program, it has renamed to ack[1][2][3]. It would be nice, if we would also update our Install page for Debian. And since Ubuntu 20.04 LTS (focal), Ubuntu also ships ack as ack [4].

@petdance, can I make a PR for this?
@n1vux
Copy link
Contributor

n1vux commented Sep 25, 2020

Oh, good news, good catch !

(We would want to keep the alias note for Debian <=9.x and Ubuntu <= 19.10 since some folks will muddle on with LTS or older Debian for various reasons.
/me whistles nonchalantly )

etanot pushed a commit to etanot/website-1 that referenced this issue Sep 25, 2020
Debian no longer ships ack-grep
6d3cc74 
Since Debian 10 (Buster), Debian no longer ships 'ack-grep'[1]. And
Debian's derivative, Ubuntu also no longer ships 'ack-grep', since
Ubuntu 20.04 LTS (focal)[2].

[1]: https://packages.debian.org/source/buster/ack
[2]: https://packages.ubuntu.com/focal/ack-grep

Resolves: beyondgrep#122
@etanot etanot mentioned this issue Sep 25, 2020
Merged
@etanot
Copy link
Contributor Author

etanot commented Sep 25, 2020

@n1vux I've submitted PR #123. Can you take a look into changes and suggest some improvements?

@n1vux
Copy link
Contributor

n1vux commented Sep 26, 2020

As noted there, looks good to me.
I've messaged Andy that I think it's Merge ready.

(In case you're wondering, no, I don't have merge priv on this Repo. I can recommend "Yup, looks good, ready" or "maybe improve here ..." but my "Yes" isn't the final "Yes".)

@petdance
Copy link
Collaborator

petdance commented Oct 4, 2020

I'll take a look at this. Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Debian no longer ships ack-grep etanot/website-1
3 participants
@petdance @n1vux @etanot