Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When migrate to Factory init, make build failed #1039

Closed
wants to merge 10 commits into from
Closed

When migrate to Factory init, make build failed #1039

wants to merge 10 commits into from

Conversation

Joey2132
Copy link
Contributor

When migrate to Factory init, make build failed with err:

2021/11/19 10:56:25 not handled type &ast.FuncType{Func:1884, Params:(*ast.FieldList)(0xc0002be0f0), Results:(*ast.FieldList)(0xc0002be120)}

And I just don't know what happend.

@Xuanwo
Copy link
Contributor

Xuanwo commented Nov 19, 2021

But the build is passed?

@Joey2132
Copy link
Contributor Author

Joey2132 commented Nov 19, 2021

But the build is passed?

The generate operation failed. So we don't support all operation. The integration_test just skipped all of them.

@Xuanwo
Copy link
Contributor

Xuanwo commented Nov 19, 2021

Oh, I got it.

2021/11/19 03:02:14 not handled type &ast.FuncType{Func:1884, Params:(*ast.FieldList)(0xc000209500), Results:(*ast.FieldList)(0xc000209560)}

We didn't exit the build with error code, so the build is not break.

@Joey2132
Copy link
Contributor Author

And without useful information, I don't realize what causes it.

@Xuanwo
Copy link
Contributor

Xuanwo commented Nov 19, 2021

Please create an issue which refer this PR, let's fix it.

@Joey2132
Copy link
Contributor Author

Please create an issue which refer this PR, let's fix it.

Got it.

@Joey2132 Joey2132 closed this Dec 1, 2021
@Joey2132 Joey2132 reopened this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants