Proposal: Add default pair for operations #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Dec 10, 2020
Xuanwo
reviewed
Dec 11, 2020
| we should handle conflict. | ||
| Since the operations with the same name handle different targets (`Servicer` and `Storager`), | ||
| I think we should handle the separately. | ||
| ```go |
|
|
||
| Since one service may just implement a part of operations in [storage], | ||
| there are two ways to define default pairs struct: | ||
| - Unify struct in [storage], so that we can maintain it only once. |
| and make sure that `pairs from args` can overwrite default pair, and this should be **generated**. | ||
| For example, we parse the pairs sequentially from the slice of pairs, | ||
| so we should create a new slice of pairs and append `pairs from args` to the slice. | ||
| ```go |
Xuanwo
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.