Only prepend player for is_singular() context #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galbus
added
wip
…llow-for-filters-eg
…llow-for-filters-eg
galbus
deleted the
s-4947-update-auto-prepending-of-player-to-allow-for-filters-eg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #374 I noticed that the code that auto-prepends the audio player HTML to the_content() could be improved – it was auto-prepending the player to
the_content()everywhere.If the player was only prepended when is_singular() then there would be no need to remove/re-add the player from
the_content()when the body for the audio content is generated.This may help to resolve #374 because I expect the paywall is only applied in frontend
is_singular()screens. In admin screens (where the body for the audio content is constructed) the entire post content should now hopefully be used for the audio body, instead of the paywalled content.This needs some manual testing to check it has no adverse effects for other publishers.