Update package.json - Svelte peer dependency, add v4 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A proposal to support the recent release of Svelte V4
Closed
|
@antony First, sorry for the tagging (I feel a little bad, forgive me if you find this rude). Can we consider moving forward with this ? On our current project, gdpr-cookie-consent-banner (which I quite glad to use) is the last dependency preventing us from migrating to svelte v4. |
|
Hey @0gust1 - absolutely. My apologies for not merging this sooner! I get so many notifications I don't see them, so thanks for reaching out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #52
A proposal to support the recent release of Svelte V4.
It was checked locally on
our SvelteKit projecttwo different production-used sveltekit-based projects, no problems so far.We may eventually check and add the
|globalmodifier on the transitions used in src/lib/Banner.svelte, but IMHO, it's not necessary.Refs: