Use Filament Panel Urls #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, panel urls are not resolved correctly when panels define both a path and a domain. Also the handling of http vs https is hardcoded. This uses Filament's default home url or panel url.
PR Summary
|
Fixes Url resolution error
Always display the link so we can switch back to the first panel when spa() mode is active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, panel urls are not resolved correctly when they define both a path and a domain. Also the handling of http vs https is hardcoded. This uses Filament's panel home url or panel url which will generate the correct url with scheme, domain and path.