Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some other widget packages use private classes for widgets - this fixes that #284

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

nicko170
Copy link
Contributor

Packages such as filament-apexcharts use private functions for getHeading() etc, which means this doesn't work.

This fixes that.

Copy link

what-the-diff bot commented Dec 11, 2023

PR Summary

  • Improved Code Functionality
    The changes in the code on line 284 of the FilamentShield.php file are aimed at enhancing our feature's efficiency. Previously, we were directly accessing the $widgetInstance which didn't yield the desired results consistently. Now, the invade function is being used, which allows us to retrieve the header information from $widgetInstance. This results in increased accuracy and reliability of our software.

@bezhanSalleh bezhanSalleh merged commit b519814 into bezhanSalleh:3.x Dec 19, 2023
5 checks passed
@bezhanSalleh
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants