Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to shield:seeder command to only generate direct permissions #329

Conversation

Jacobtims
Copy link
Contributor

This PR will add an --option option to the shield:seeder command.
This option supports two choices:

  1. permissions_via_roles: Only generate the seeder with permissions via roles
  2. direct_permissions: Only generate the seeder with direct permissions

Will fix #309

Copy link

what-the-diff bot commented Feb 6, 2024

PR Summary

  • Introduction of New Option in Command
    A new option, --option, has been added to the shield:seeder command, allowing the usage of permissions_via_roles and direct_permissions, enhancing user flexibility during interaction with the program.

  • Enhancement of Check Logic
    The previous static system checks via Utils::getRoleModel()::exists() and Utils::getPermissionModel()::exists() have been replaced with a more dynamic evaluation method, leading to improved system response and reducing the chance of errors.

  • Updates in Conditional Logic
    There is an adjustment in logic linked to if conditions, which now comprehensively scrutinizes the new --option value, optimizing the software's decision-making capability.

  • Addition in Mapping and Filtering Logic
    An enhancement has been made to the $directPermissions collection. The update provides additional mapping and filtering logic, granting an improved and more efficient data organization.

@bezhanSalleh bezhanSalleh merged commit 631bbd7 into bezhanSalleh:3.x Feb 14, 2024
1 check passed
@bezhanSalleh
Copy link
Owner

Thanks

@Jacobtims
Copy link
Contributor Author

@bezhanSalleh When do you plan to release this?

@bezhanSalleh
Copy link
Owner

When I or someone else have the time to do a final review of PR #336. If you have the time I appreciate the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Only create seeder for permissions
2 participants