Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Not generate super_admin role when disabled #381

Merged
merged 3 commits into from
May 14, 2024

Conversation

bezhanSalleh
Copy link
Owner

fixes #371

Copy link

what-the-diff bot commented May 14, 2024

PR Summary

  • Update to Super Admin Permission Method
    Updated the method that grants super admin permissions to perform a check if the super admin is enabled before creating the role. This change adds a layer of permission verification, thereby enhancing the security of the system.

  • Logic Addition for Unique Page Retrieval
    Enhanced the logic of retrieving pages. Now, this function can filter out clustered pages and return a unique list of pages, enhancing the efficiency and accuracy of the page retrieval process.

  • Method Renaming and Update
    The method previously known as canView has been renamed to canAccess for clarity. This change should align with the intent of the function more accurately, ensuring clearer understanding for future maintenance.

  • Removed the Parameter from a Method
    Updated the shouldRegisterNavigation method by removing the $parameters parameter. The logic of the method is now set to check for access permissions instead of view permissions. This alteration is set to refine the access control, bolstering application security.

@bezhanSalleh bezhanSalleh merged commit aa1046d into 3.x May 14, 2024
21 checks passed
@bezhanSalleh bezhanSalleh deleted the fix/super-admin-role branch May 14, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

super_admin role generation
1 participant