Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads file over 100% when continuing downloading from package info #44

Closed
Morasiu opened this issue Mar 23, 2021 · 4 comments · Fixed by #45
Closed

Downloads file over 100% when continuing downloading from package info #44

Morasiu opened this issue Mar 23, 2021 · 4 comments · Fixed by #45
Assignees
Labels
bug Something isn't working

Comments

@Morasiu
Copy link

Morasiu commented Mar 23, 2021

Version: 2.2.4

image

When my app is loading a saved package from the file (serialized in binary) and continuing downloading, the Downloader is downloading and reporting progress over 100% (and over TotalBytes)! (Check BytesReceived and Percent)

It only happens when Downloader is continuing from the package.

My config:

var config = new DownloadConfiguration {
		CheckDiskSizeBeforeDownload = true,
		OnTheFlyDownload = false,
	};

Suggestions:

  • My config is using OnTheFlyDownload as false. I think that when is was true I didn't have that issue.
  • My code for saving and loading package info is here. Maybe there is something wrong?
@bezzad bezzad self-assigned this Mar 24, 2021
@bezzad bezzad added the bug Something isn't working label Mar 24, 2021
@bezzad bezzad linked a pull request Mar 24, 2021 that will close this issue
@bezzad
Copy link
Owner

bezzad commented Mar 24, 2021

@Morasiu Please check the new version 2.2.5 for this issue.
If you found any problem please re-open this issue. thanks for reporting.

@Morasiu
Copy link
Author

Morasiu commented Mar 24, 2021

Looks like it always starts downloading from the beginning now. Even, when using the package as an argument.

Also, I cannot reopen this issue, since I don't have the right to the repo and I am not the one who closed it.

@bezzad
Copy link
Owner

bezzad commented Mar 24, 2021

The Temp files that hold the information to the chunks are probably deleted. Please change the DownloadConfigration.TempDirectory address or make sure the files in the temp path of the operating system are safe. If this information is deleted after saving the package, it is impossible to continue downloading. Unless you use OnTheFly mode where buffer chunk information is stored on RAM.

@bezzad
Copy link
Owner

bezzad commented Mar 24, 2021

If you have another problem again, please open the new issue. Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants