MGDCTRS-1869 MGDCTRS-1870 Add missing config options to connector catalog #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ani-sha, I added a comment to MGDCTRS-1870. Ideally, we need an upstream change to the schema generation tooling to specify which |
Naros
approved these changes
Jan 18, 2023
rk3rn3r
reviewed
Jan 23, 2023
| @@ -459,7 +473,7 @@ objects: | |||
| "icon_href" : "http://example.com/images/debezium-postgres-2.0.1.Final.png", | |||
| "schema" : { | |||
| "title" : "Debezium PostgreSQL Connector", | |||
| "required" : [ "topic.prefix", "database.hostname", "database.user", "database.dbname" ], | |||
| "required" : [ "topic.prefix", "database.hostname", "database.user" ], | |||
There was a problem hiding this comment.
@Naros is database.names really an optional config option?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MGDCTRS-1869
https://issues.redhat.com/browse/MGDCTRS-1870