Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate size limits in the KafkaRequest schema #1183

Conversation

JasonPowr
Copy link
Contributor

Description

The KafkaRequest schema contains the following fields providing information on the instance size limits:
- egress_throughput_per_sec
- ingress_throughput_per_sec
- instance_type_name
- max_connection_attempts_per_sec
- max_data_retention_period
- max_partitions
- total_max_connections

In this PR these fields have been marked for deprecation
Jira: https://issues.redhat.com/browse/MGDSTRM-8967

Checklist (Definition of Done)

  • All acceptance criteria specified in JIRA have been completed
  • Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer
  • All PR comments are resolved either by addressing them or creating follow up tasks
  • Required metrics/dashboards/alerts have been added (or PR created).
  • Required Standard Operating Procedure (SOP) is added.
  • JIRA has been created for changes required on the client side

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1183 (f66299f) into main (8791d0b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   82.51%   82.51%           
=======================================
  Files         131      131           
  Lines       11396    11396           
=======================================
  Hits         9403     9403           
  Misses       1638     1638           
  Partials      355      355           
Flag Coverage Δ
unittests 82.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/kafka/internal/presenters/kafka.go 98.98% <100.00%> (ø)

Copy link
Contributor

@JameelB JameelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @JasonPowr, lgtm!

@JasonPowr JasonPowr force-pushed the deprecate-size-limits-in-kafkaRequest-schema branch from db1d06d to f66299f Compare July 14, 2022 15:56
@machi1990 machi1990 merged commit 5d2f711 into bf2fc6cc711aee1a0c2a:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants