fix(db): honors enable-db-debug flag when set to true #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machi1990
force-pushed
the
fix/ensure-logs-are-there-in-debug
branch
from
22e6762
to
81bc09f
Compare
The custom logger didn't print the sql statements which are useful during debugging. I ran into this issue when testing something locally. Let's honor this flag by using the default logger that comes with gorm to print the SQL statements. To verify the changes: - 1. Before this patch, build the binary and run `./kas-fleet-manager serve --enable-db-debug=true` this wouldn't print the SQL statements - 2. Apply this patch locally, built the binary and run `./kas-fleet-manager serve --enable-db-debug=true` and observe the printed SQL statements - 3. Disabe db debug by run `./kas-fleet-manager serve --enable-db-debug=false` again with code changes on this patch and observe that no SQL statements are printed out
machi1990
force-pushed
the
fix/ensure-logs-are-there-in-debug
branch
from
81bc09f
to
4af99a5
Compare
|
Thanks @Rajagopalan-Ranganathan for the review and approval. Let's get this in as I might need to cherry-pick this into factorized fleet manager template. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The custom logger didn't print the sql statements which are useful during debugging. I ran into this
issue when testing something locally. Let's honor this flag by using the default logger that comes
with gorm to print the SQL statements.
Verification Steps
To verify the changes:
./kas-fleet-manager serve --enable-db-debug=truethis wouldn't print the SQL statements./kas-fleet-manager serve --enable-db-debug=trueand observe theprinted SQL statements
./kas-fleet-manager serve --enable-db-debug=falseagain with code changes on this patch and observe that no SQL statements are printed outChecklist (Definition of Done)
[ ] All acceptance criteria specified in JIRA have been completed[ ] Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)[ ] Documentation added for the featureThere will be a troubleshooting guide and the usage of this flag might go there[ ] CI and all relevant tests are passing[ ] Required metrics/dashboards/alerts have been added (or PR created).[ ] Required Standard Operating Procedure (SOP) is added.[ ] JIRA has created for changes required on the client side