Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGDSTRM-8837 adding the quota consumed metric #748

Merged
merged 1 commit into from
Jul 11, 2022
Merged

MGDSTRM-8837 adding the quota consumed metric #748

merged 1 commit into from
Jul 11, 2022

Conversation

shawkins
Copy link
Contributor

No description provided.

@shawkins shawkins marked this pull request as ready for review June 21, 2022 12:40
@github-actions github-actions bot added the operator changes related to operator label Jun 21, 2022
@MikeEdgar MikeEdgar added this to the 0.25.0 milestone Jun 22, 2022
rareddy
rareddy approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

MikeEdgar
MikeEdgar approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I thought I had already review this!

@pb82
Copy link

pb82 commented Jun 28, 2022

@shawkins @rareddy is there a planned release for this already?

@rareddy
Copy link
Contributor

rareddy commented Jun 28, 2022

@shawkins @rareddy is there a planned release for this already?

This should be next release of FSO, I do not have a date yet.

@shawkins
Copy link
Contributor Author

shawkins commented Jul 7, 2022

@k-wall any qualms with this additional metric?

k-wall
k-wall approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@k-wall k-wall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shawkins shawkins merged commit 14869b0 into bf2fc6cc711aee1a0c2a:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rareddy rareddy rareddy approved these changes

@k-wall k-wall k-wall approved these changes

@MikeEdgar MikeEdgar MikeEdgar approved these changes

Assignees
No one assigned
Labels
operator changes related to operator
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shawkins @pb82 @rareddy @k-wall @MikeEdgar