Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGDSTRM-8601- Allow configuration of Kafka exporter image via bundle #758

Merged
merged 5 commits into from
Jul 11, 2022
Merged

MGDSTRM-8601- Allow configuration of Kafka exporter image via bundle #758

merged 5 commits into from
Jul 11, 2022

Conversation

biswassri
Copy link
Contributor

@biswassri biswassri commented Jun 23, 2022 •
edited
Loading

Adding exporter image to operator

@github-actions github-actions bot added the operator changes related to operator label Jun 23, 2022
@biswassri biswassri requested a review from MikeEdgar June 23, 2022 18:55
MikeEdgar
MikeEdgar requested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs the pull secret configuration added to the pod template.

operator/src/main/java/org/bf2/operator/operands/KafkaCluster.java Show resolved Hide resolved
@MikeEdgar
Copy link
Contributor

@biswassri looks good, but I think it's still missing the changes to the test expectation.

@biswassri
Copy link
Contributor Author

biswassri commented Jul 5, 2022 •
edited
Loading

@biswassri looks good, but I think it's still missing the changes to the test expectation.

Right, I'll put in the yml changes sometime. By additional tests are you taking about unit tests? I wasn't able to come up with test scenarios. Can we discuss more possible scenarios?

MikeEdgar
MikeEdgar approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rareddy
rareddy approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rareddy
Copy link
Contributor

rareddy commented Jul 11, 2022

@biswassri @MikeEdgar can we put this into 0.25 build? what is holding up the merge?

@biswassri
Copy link
Contributor Author

biswassri commented Jul 11, 2022 •
edited
Loading

@rareddy I'm in the process of deploying this in an OSD. I haven't had success with it. So I was waiting to get that through. @MikeEdgar If you think we can go without it, I'm good to merge.

@MikeEdgar
Copy link
Contributor

@biswassri what issue with OSD are you having? I deployed this via a bundle earlier without any issues, so I am fine with merging.

@biswassri
Copy link
Contributor Author

@MikeEdgar It's my kas-installer. But, if it worked for you, I'll go ahead and merge it. Do you want to add the Milestone to it?

@MikeEdgar MikeEdgar added this to the 0.25.0 milestone Jul 11, 2022
@MikeEdgar
Copy link
Contributor

Do you want to add the Milestone to it?

Done

@biswassri biswassri merged commit c99f055 into bf2fc6cc711aee1a0c2a:main Jul 11, 2022
@biswassri biswassri deleted the exporter-image branch August 4, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rareddy rareddy rareddy approved these changes

@MikeEdgar MikeEdgar MikeEdgar approved these changes

Assignees
No one assigned
Labels
operator changes related to operator
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@biswassri @MikeEdgar @rareddy