-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGDSTRM-9050: expose generic mechanism for injecting additional broker configuration from the operand override #767
Conversation
…r configuration from the operand override
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feature. Overall LGTM. Left a comment. Also, I think we should put the PR description into somewhere, maybe README? wiki? Or...?
operator/src/main/java/org/bf2/operator/managers/OperandOverrideManager.java
Outdated
Show resolved
Hide resolved
I added a section to ADVANCED.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Happy for this to merge as is, my comments are optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding doc in ADVANCED.md. LGTM! Left a minor comment.
@MikeEdgar any comments from you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Using this mechanism, we can override configuration passed to the broker by populating the
brokerConfig
object on the operator override. This will have utility for temporary feature flags as well as experimentation in dev. Note you can remove a broker config key by passing a null value.and showing it works end to end: