Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGDSTRM-10459 changing the reloadInterval tuning option to a string #859

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

shawkins
Copy link
Contributor

We need to leave the unsupport option as an int, but change the tuning option to a string.

@github-actions github-actions bot added the operator changes related to operator label Jan 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I am assuming this works in versions 4.10 and above? I mean string conversion is not specific to 4.12+

@shawkins
Copy link
Contributor Author

I am assuming this works in versions 4.10 and above? I mean string conversion is not specific to 4.12+

The failure is due to the compatibility logic that I had already put in. In both 4.11 and 4.12 the openshift cluster ingress operator moved properties from unsupported to tuning options. In doing so if you simply left the cr with the unsupported option, that feature will no longer be enabled. So the logic rather than performing a version check is setting the properties in both tuning options and unsupported properties. If the tuning option does not exist on 4.10 or 4.11, it is simply dropped by the api server.

@shawkins shawkins merged commit 90e58d0 into bf2fc6cc711aee1a0c2a:main Jan 23, 2023
@MikeEdgar MikeEdgar added this to the 0.33.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operator changes related to operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants