Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGDSTRM-10985 accounting for the possibility of competing operators #886

Merged
merged 1 commit into from
Mar 24, 2023
Merged

MGDSTRM-10985 accounting for the possibility of competing operators #886

merged 1 commit into from
Mar 24, 2023

Conversation

shawkins
Copy link
Contributor

With later josdk we'll likely enable leader election.

@github-actions github-actions bot added the operator changes related to operator label Mar 23, 2023
@MikeEdgar
Copy link
Contributor

Can we use io.javaoperatorsdk.operator.api.config.LeaderElectionConfiguration even with the current platform?

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@shawkins
Copy link
Contributor Author

Can we use io.javaoperatorsdk.operator.api.config.LeaderElectionConfiguration even with the current platform?

There have been a lot of fixes / improvements in the leader election logic since 5.12.4, I'm honestly not sure if a 5.x version is appropriate for general use - I was just going to wait until we were on a later version.

@MikeEdgar
Copy link
Contributor

Ok, got it. I didn't realize it might not be ready.

MikeEdgar
MikeEdgar approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rareddy
rareddy approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MikeEdgar MikeEdgar added this to the 0.35.0 milestone Mar 23, 2023
@shawkins shawkins merged commit 0aa6d8f into bf2fc6cc711aee1a0c2a:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rareddy rareddy rareddy approved these changes

@MikeEdgar MikeEdgar MikeEdgar approved these changes

Assignees
No one assigned
Labels
operator changes related to operator
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shawkins @MikeEdgar @rareddy