Help not working in sub-command example

[Morwenn]

I was trying to get lyra::help to work with the add_argument interface and the sub-command example has just that. However, it looks like --help is not working in this case. I got it to work by moving the cli.parse invocation before the check for show_help - I believe that it's the right fix (parsing the command line for --help before checking the corresponding flag makes sense to me) but it's my first time trying Lyra so I can't really be sure.

I believe that it was introduced when implementing the fix for #16.

[grafikrobot]

Can you post what commands you tried and what you expected?

[Morwenn]

I tried that nugget of code from the documentation:

/* [insert definitions of run_command and kill_command here] */

int main(int argc, const char** argv)
{
    auto cli = lyra::cli_parser();
    std::string command;
    bool show_help = false;
    cli.add_argument(lyra::help(show_help));
    cli.add_argument(lyra::arg(command, "command") 
                         .choices(run_command::name(), kill_command::name())
                         .required()
                         .help("Command to perform."));
    if (show_help)
    {
        std::cout << cli;
        return 0;
    }
    auto result = cli.parse({ argc, argv });
    /* ... */
}

Then I tried to call the resulting program with --help and it didn't work: I had to put the cli.parse() line above the check for show_help to make it work properly.

I know that this specific example is not really about showing how to use lyra::help with the add_argument interface, but it's the only example in the documentation which does so, so I just copied that part and expected it to work.

[grafikrobot]

Sorry it took a bit.. But it looks like this is a duplicate error report. It was fixed some time ago: 5657ff1

Thanks for reporting the problem and for using the library.

[Morwenn]

Indeed, I apparently missed that one. Thanks for maintaining the library :)