2 player controls don't work on keyboards without numpads

[bfirsh]

Thanks Linkandar Airimder for the report, via email:

I discovered that the controls for 2-player mode are unplayable to someone on a laptop without a number pad. If you would be so kind, would you be willing to change the controls to something similar to the 1st players? Nearly any control scheme would be preferable to the current.

[Liam-Newell]

Hey! @bfirsh I'd love to work on this as my first bug. Do you mind if i try to make a pull request for this? and do you have an suggestions?

[Liam-Newell]

I was thinking of adding an alternate button just next to the P2 control layout

[bfirsh]

Yeah please!

I’m not sure what the best solution is to be honest. The downside of being right next to each other is that isn’t actually practical to play. (Imagine two people actually trying to do that.)

[Liam-Newell]

I think for those comforable enough i think it can be done 😂 https://youtu.be/H_I9b6nBGAM

…

On Wed, Mar 21, 2018, 2:40 AM Ben Firshman, ***@***.***> wrote: Yeah please! I’m not sure what the best solution is to be honest. The downside of being right next to each other is that isn’t actually practical to play. (Imagine two people actually trying to do that.) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#65 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABSY3_qPQNQA0bHb3q-B9bbh3JCaF3kbks5tgfWwgaJpZM4SxdoR> .

[Liam-Newell]

@bfirsh Oh, I didn't know if your comment was trying to on this, but after review of some other flash games it pretty popular to have p1 do wasd and p2 arrows keys(and so on)

[bfirsh]

Yes, that seems reasonable, but it also needs to be done in a backwards compatible way.

Perhaps we could make P2 wasd, then add some P1 controls A/B/Start/Select controls near the arrow keys. Hmmmm. That seems overly complex.

[Liam-Newell]

Personally I like the left to right idea for control but its your thing, currently its assigned to p1 wasd p2 arrow keys; with p1 having G & H for A & B and p2 having ; & ' for A & B

[Liam-Newell]

I'm confused, are you referring to something else you're working on, or my work here? @studywithyou

[bfirsh]

Fixed by #136.