Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructional thing part ii #15

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

jbdunne
Copy link

@jbdunne jbdunne commented Sep 18, 2014

Assignment 2 for Jason Dunne

@afeld
Copy link
Member

afeld commented Oct 9, 2014

Nice work. Clean, clear, and consistent. Design-wise, only a couple pieces of feedback:

  • The guitar name being the same font/size as the descriptive text doesn't divide the sections very well. You could achieve this by:
    • Adding visual separation, e.g.
    • Making the guitar names larger, bolder, or a different font
    • As suggested in class, using the brand logo instead of the names
  • The text+image+video for each guitar is too large to fit on one screen, so I can't even remember the name of the guitar by the time I get to the video. Maybe something like a sticky header would do the trick? This could also help with the section separation discussed in the previous point.

To get this thing showcase-worty, please:

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants