Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved index.html directly into the instructional folder #18

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from

Conversation

susfor
Copy link

@susfor susfor commented Sep 22, 2014

No description provided.

else if (stepindex == 8){
img.src="images/step1.svg";
stepindex = 1;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this in person, but if you're copying-and-pasting code, there's probably an easy way to refactor it. How would you make this more concise?

@afeld
Copy link
Member

afeld commented Oct 9, 2014

I told you before, but really liked this project. Illustrated the steps clearly, and I didn't have any doubt that I could braid after going through it. Now just need to grow my hair long enough to try it.

<img id="image" src="images/step1.svg"/>
<br><br>
<button id="clickme" onclick="changeImage();">Click to see the next step!</button>
</center>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the automated feedback, how would you center this part of the page without the <center> element?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants