Added timeout and docker file directory #22
Conversation
…sed to shell_out command.
…contains the dockerfile
| @@ -36,3 +36,4 @@ | |||
| attribute :privileged, :kind_of => [TrueClass, FalseClass] | |||
| attribute :user, :kind_of => [String] | |||
| attribute :volume, :kind_of => [String] | |||
| attribute :cmd_timeout, :kind_of => [Integer] | |||
There was a problem hiding this comment.
Can we not just set the :default => 60 here rather than all the || 60 for each shell_out? Also is there a specific reason for 60 seconds versus any other arbitrary value?
There was a problem hiding this comment.
Same as image: Should this just be called timeout instead? While the current implementation is shell_out, I think the feature should be abstracted away.
There was a problem hiding this comment.
I'm adding in the :default => 60. The reason for choosing 60 is because it is the default value for the shell_out command, so I figured it would be reasonable to maintain that. As far as the timeout vs cmd_timeout, I had tried that at first but it was causing issues because it was overridden by a built in chef attribute.
|
A few changes in this pull request and I'll get this merged. Thanks for the contribution! |
…dockerfile_directory attribute to be path instead.
|
Great thanks for the clarifications. |
I added the option of passing a timeout parameter to the shell out method to prevent an erroneous failure due to long-running image builds. I also added the option to pass the directory that contains the dockerfile so that the ADD parameter in the dockerfile can be supported.