Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout and docker file directory #22

Merged
merged 5 commits into from
Nov 7, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions providers/container.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

def load_current_resource
@current_resource = Chef::Resource::DockerContainer.new(new_resource)
dps = shell_out("docker ps -a -notrunc")
dps = shell_out("docker ps -a -notrunc", :timeout => new_resource.cmd_timeout)
dps.stdout.each_line do |dps_line|
next unless dps_line.include?(new_resource.image) && dps_line.include?(new_resource.command)
container_ps = dps_line.split(%r{\s\s+})
Expand Down Expand Up @@ -62,7 +62,8 @@ def load_current_resource
run_args += " -privileged" if new_resource.privileged
run_args += " -u #{new_resource.user}" if new_resource.user
run_args += " -v #{new_resource.volume}" if new_resource.volume
dr = shell_out("docker run #{run_args} #{new_resource.image} #{new_resource.command}")
run_args += " -w #{new_resource.working_directory}" if new_resource.working_directory
dr = shell_out("docker run #{run_args} #{new_resource.image} #{new_resource.command}", :timeout => new_resource.cmd_timeout)
new_resource.id(dr.stdout.chomp)
new_resource.updated_by_last_action(true)
end
Expand All @@ -79,21 +80,21 @@ def load_current_resource
end

def remove
shell_out("docker rm #{current_resource.id}")
shell_out("docker rm #{current_resource.id}", :timeout => new_resource.cmd_timeout)
end

def restart
shell_out("docker restart #{current_resource.id}")
shell_out("docker restart #{current_resource.id}", :timeout => new_resource.cmd_timeout)
end

def running?
@current_resource.running
end

def start
shell_out("docker start #{current_resource.id}")
shell_out("docker start #{current_resource.id}", :timeout => new_resource.cmd_timeout)
end

def stop
shell_out("docker stop #{current_resource.id}")
shell_out("docker stop #{current_resource.id}", :timeout => new_resource.cmd_timeout)
end
13 changes: 9 additions & 4 deletions providers/image.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

def load_current_resource
@current_resource = Chef::Resource::DockerImage.new(new_resource)
di = shell_out("docker images -a")
di = shell_out("docker images -a", :timeout => new_resource.cmd_timeout)
if di.stdout.include?(new_resource.image_name)
di.stdout.each_line do |di_line|
next unless di_line.include?(new_resource.image_name)
Expand All @@ -42,7 +42,7 @@ def load_current_resource
pull_args = ""
pull_args += " -registry #{new_resource.registry}" if new_resource.registry
pull_args += " -t #{new_resource.tag}" if new_resource.tag
shell_out("docker pull #{new_resource.image_name} #{pull_args}")
shell_out("docker pull #{new_resource.image_name} #{pull_args}", :timeout => new_resource.cmd_timeout)
new_resource.updated_by_last_action(true)
end
end
Expand All @@ -51,7 +51,12 @@ def load_current_resource
unless installed?
full_image_name = new_resource.image_name
full_image_name += ":#{new_resource.tag}" if new_resource.tag
shell_out("docker build -t #{full_image_name} - < #{new_resource.dockerfile}")
if new_resource.dockerfile
command = "- < #{new_resource.dockerfile}"
elsif new_resource.path
command = "#{new_resource.path}"
end
shell_out("docker build -t #{full_image_name} #{command}", :timeout => new_resource.cmd_timeout)
new_resource.updated_by_last_action(true)
end
end
Expand All @@ -62,7 +67,7 @@ def load_current_resource
end

def remove
shell_out("docker rmi #{new_resource.image_name}")
shell_out("docker rmi #{new_resource.image_name}", :timeout => new_resource.cmd_timeout)
end

def installed?
Expand Down
2 changes: 2 additions & 0 deletions resources/container.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,5 @@
attribute :privileged, :kind_of => [TrueClass, FalseClass]
attribute :user, :kind_of => [String]
attribute :volume, :kind_of => [String]
attribute :working_directory, :kind_of => [String]
attribute :cmd_timeout, :kind_of => [Integer], :default => 60
2 changes: 2 additions & 0 deletions resources/image.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,5 @@
attribute :repository, :kind_of => [String]
attribute :tag, :kind_of => [String]
attribute :dockerfile, :kind_of => [String]
attribute :cmd_timeout, :kind_of => [Integer], :default => 60
attribute :path, :kind_of => [String]