Deprecate the 'restart' daemon option (obsolete since docker 1.2.0). #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 18, 2014
|
Great! Thanks! |
tduffield
pushed a commit
that referenced
this pull request
Nov 19, 2014
Deprecate the 'restart' daemon option (obsolete since docker 1.2.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found out that the
--restartdaemon option has been obsoleted in docker 1.2.0. The option is no longer documented and even if its presence won't prevent the docker daemon to start, it will be ignored. The container restart is now done with explicit restart policies.This PR deprecates the attribute (which we can keep for now, no harm); we should remove it with version 1.0.0 of the cookbook.