Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Go environment only when installing from source #25

Merged

Conversation

mpasternacki
Copy link
Contributor

No description provided.

@bflad
Copy link
Contributor

bflad commented Nov 7, 2013

I like the idea, but I think we'll want to keep the source installation recipe strictly to just installing the source in case folks want to manage their Go environment separately.

I'd prefer to wrap those two lines in the default recipe with an if statement (install type source) so it's only handled if you're using the cookbook's default method of installing your Go environment.

Can you make the above adjustment and I'll merge? Thanks.

@mpasternacki
Copy link
Contributor Author

Done.

@bflad
Copy link
Contributor

bflad commented Nov 7, 2013

LGTM

bflad added a commit that referenced this pull request Nov 7, 2013
…llation

Install Go environment only when installing from source
@bflad bflad merged commit e17da45 into sous-chefs:master Nov 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants