Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access keyserver.ubuntu.com on port 80 #265

Merged
merged 1 commit into from Mar 3, 2015

Conversation

Sauraus
Copy link

@Sauraus Sauraus commented Jan 29, 2015

This resolves #264

@Sauraus
Copy link
Author

Sauraus commented Jan 29, 2015

Those Travis errors already exist on trunk, which forked a few minutes before submitting my pull request.

@tduffield
Copy link
Contributor

So I'm not super convinced that port 80 should be the default. I think it would be better to make a note in the README about this and to offer an example about how you would override this in your local environment.

@djdefi
Copy link

djdefi commented Feb 20, 2015

I agree there @tduffield

@gionn
Copy link
Contributor

gionn commented Feb 28, 2015

@tduffield @rtrauntvein state reasons instead of opinions, this is a good workaround for users behind restrictive firewalls and should cause no-harm to everyone else.

@tduffield
Copy link
Contributor

@Sauraus if you rebase this PR on master and Travis passes I'll merge it in. Given that Docker itself uses port 80 in it's installation procedures I no longer see a reason to enforce the default.

- Added RubyMine .idea/ folder to .gitignore
@Sauraus
Copy link
Author

Sauraus commented Mar 2, 2015

@tduffield rebased and recommitted.

NOTE: The travis failure was already present on master, not my doing. ;)

tduffield pushed a commit that referenced this pull request Mar 3, 2015
Access keyserver.ubuntu.com on port 80
@tduffield tduffield merged commit 250d0fa into sous-chefs:master Mar 3, 2015
bflad added a commit that referenced this pull request Apr 14, 2015
bflad added a commit that referenced this pull request Apr 14, 2015
Rspec fixes mostly from #250 and #265 changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyserver.ubuntu.com default port is often blocked
4 participants