Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #284, runit finish script to stop a container #285

Merged
merged 2 commits into from
Apr 14, 2015
Merged

fixes #284, runit finish script to stop a container #285

merged 2 commits into from
Apr 14, 2015

Conversation

xmik
Copy link
Contributor

@xmik xmik commented Mar 18, 2015

See #284.

@xmik
Copy link
Contributor Author

xmik commented Mar 19, 2015

I think the runit service (chef resource) option: restart_on_update should be set to false, to not restart docker container when the runit script is updated. I will test it more. For now it failed with the data container, it tried to restart not running container.

@xmik
Copy link
Contributor Author

xmik commented Mar 20, 2015

I tested on data container (not running as a daemon) and on not data container (running as a daemon) and it works for me. The virtual machine I tested on:

vagrant@vm:~$ cat /etc/debian_version 
7.5
vagrant@vm:~$ uname -r
3.14-0.bpo.2-amd64

Edit: all the failures of Travis build concern /etc/default/docker file, they do not concern this pull request.

@bflad
Copy link
Contributor

bflad commented Apr 14, 2015

This seems good to me -- I'll get this in. Thanks!

bflad added a commit that referenced this pull request Apr 14, 2015
fixes #284, runit finish script to stop a container
@bflad bflad merged commit 8ab9473 into sous-chefs:master Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants