Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CommandTimeout handling #68

Merged
merged 1 commit into from
Feb 11, 2014
Merged

Conversation

jcrobak
Copy link

@jcrobak jcrobak commented Feb 11, 2014

The refactor broke CommandTimeout handling, which will result
in a NameError. This fixes it by adding a new CommandTimeout
exception in scope and removing the old classes.

Here's an example error message:


       NameError

       ---------
       uninitialized constant Helpers::Docker::CommandTimeout


       Cookbook Trace:
       ---------------
       /tmp/kitchen/cookbooks/docker/libraries/helpers.rb:104:in `rescue in execute_cmd'
       /tmp/kitchen/cookbooks/docker/libraries/helpers.rb:101:in `execute_cmd'
       /tmp/kitchen/cookbooks/docker/libraries/helpers.rb:117:in `execute_cmd!'
       /tmp/kitchen/cookbooks/docker/libraries/helpers.rb:111:in `docker_cmd!'
       /tmp/kitchen/cookbooks/docker/providers/image.rb:202:in `pull'
       /tmp/kitchen/cookbooks/docker/providers/image.rb:70:in `block in class_from_file'

if you have a timeout.

The refactor broke CommandTimeout handling, which will result
in a NameError. This fixes it by adding a new CommandTimeout
exception in scope and removing the old classes.
@bflad
Copy link
Contributor

bflad commented Feb 11, 2014

LGTM

bflad added a commit that referenced this pull request Feb 11, 2014
@bflad bflad merged commit 74dc443 into sous-chefs:master Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants