Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use to_f instead of Float #4

Merged
merged 1 commit into from
Jan 17, 2015
Merged

use to_f instead of Float #4

merged 1 commit into from
Jan 17, 2015

Conversation

fauno
Copy link
Contributor

@fauno fauno commented Jan 15, 2015

the added benefit is that 'NaN' values won't make the parser fail

@bfoz
Copy link
Owner

bfoz commented Jan 15, 2015

Good catch. Thanks.

Can I get you to squash the two commits before I pull this? I prefer to keep the tests for a feature in the commit that added the feature that's being tested. BTW it looks like the new test's formatting got borked somehow.

@fauno
Copy link
Contributor Author

fauno commented Jan 15, 2015

Brandon Fosdick notifications@github.com writes:

Good catch. Thanks.

Can I get you to squash the two commits before I pull this? I prefer

of course :)

to keep the tests for a feature in the commit that added the feature
that's being tested. BTW it looks like the new test's formatting got
borked somehow.

i saw it too, are you using tabs? i tried to set noexpandtab but the
format was still borked and i prefered not to touch it

P)

@bfoz
Copy link
Owner

bfoz commented Jan 15, 2015

I set indentations to 4 characters, and tabs to 8. I know, it's old school, but I like it.

@fauno
Copy link
Contributor Author

fauno commented Jan 15, 2015

Brandon Fosdick notifications@github.com writes:

I set indentations to 4 characters, and tabs to 8. I know, it's old school, but I like it.

ok i'll fix the indentation, squash the commits and get back to you

P)

the added benefit is that 'NaN' values won't make the parser fail
@fauno
Copy link
Contributor Author

fauno commented Jan 16, 2015

there you go, the indentation looks ok here :)

@bfoz bfoz merged commit 226089d into bfoz:master Jan 17, 2015
@bfoz
Copy link
Owner

bfoz commented Jan 17, 2015

Perfect. Thanks!

@fauno fauno deleted the use_to_f branch January 21, 2015 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants