Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.0 #145

Merged
merged 11 commits into from
Jul 11, 2018
Merged

Version 2.0 #145

merged 11 commits into from
Jul 11, 2018

Conversation

bfwg
Copy link
Owner

@bfwg bfwg commented Jun 16, 2018 •
edited

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Update directive to a container component.
  • Introduce drag-scroll-item directive to mark children components.
  • Restructure code for better readability.
  • Refactor build script.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Yes.
    dragScroll directive is no longer supported. Please use <drag-scroll></drag-scroll> instead.

Related to #66

Huge thank to @joejordanbrown

@bfwg bfwg mentioned this pull request Jun 17, 2018
Closed
@bfwg bfwg changed the title Drag scroll item Version 2.0 Jun 17, 2018
@bfwg bfwg merged commit 8b1ecc2 into develop Jul 11, 2018
@bfwg bfwg deleted the drag-scroll-item branch July 11, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bfwg