-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Release #29
Prepare Release #29
Conversation
@cah-brian-gantzler @NullVoxPopuli to get this PR to show what the release will actually look like you will need to label all of the above PRs 馃檲 sorry for asking you to do extra work but I promise it will be worth it once it's done 馃槀 |
Looks like we need settings changes: https://github.com/bgantzler/ember-mirage/actions/runs/8081564305/job/22080451925#step:7:150 |
This might be the NPM_TOKEN Chris said needs created. If Im the only one that can change settings, would be happy to change, might need some instructions on what to change. I thought I have given @NullVoxPopuli the highest rights he could have. Was hoping that included settings |
So same, if a setting needs changed let me know and Ill change it. If this NPM_TOKEN needs created in the secrets, I can create it, but kinda new at this level, where how do I get the token to put in there |
Following the documentation I found, the GITHUB_TOKEN is defined correctly. I checked the NPM_TOKEN and there was one defined 3 years ago. On the off change that perhaps it did not have the correct permissions, I recreated one and updated it. |
@bgantzler that sounds great! now all we need to do is to rerun this job and I think we're good https://github.com/bgantzler/ember-mirage/actions/runs/8069697918 FYI this experience will be better going forward, the job that runs when you label a PR didn't exist for anything before release-plan was setup so we need to re-run the job on the main branch to fix this 馃憤 |
Also regarding:
Unfortunately when a project is in your personal set of repos there is no way to give anyone else enough permissions to do this sort of stuff 馃槥 you need to have it be a part of an org and you can set people up that way. It's unfortunate but c'est la vie 馃檭 |
I did re-run the job, it failed in the same place. Its almost like the block here https://github.com/bgantzler/ember-mirage/blob/release-preview/.github/workflows/plan-release.yml#L37 isnt being honored. Even weirder, the previous attempts failed after less than a minute. The third attempted I see failed in the same place, but got hung cleaning up orphaned processes. I cancelled after 17 minutes. Dont know how long it would have ran. Update: Looks like unfortunate timing. There is now a Github incident involving actions and pull requests |
7a62c60
to
23ad8e4
Compare
oh that's looking a lot better 馃槏 although I think I messed something up when i reset the blueprint, it looks like It's trying to release a v0.1.0 but the current version is already v0.2.0. PR incoming 馃憤 |
23ad8e4
to
858ba20
Compare
much better 馃帀 This is ready to merge now if we want to try releasing 馃槺 |
This PR is a preview of the release that release-plan has prepared. To release you should just merge this PR 馃憤
Release (2024-03-06)
ember-mirage 0.3.0 (minor)
馃殌 Enhancement
ember-mirage
馃摑 Documentation
馃彔 Internal
ember-mirage
test-app
ember-mirage
,test-app
Committers: 3