-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suffix assignment to sGLFluxPartition output is not complete and leads to overwriting #17
Comments
Originally, Hence, for repeated processing, please, instantiate a new object before, or use the functions that are not part of Regarding the additional output columns: If you make a strong case for a common use case, that requires the distribution of some specific intermediate results, we could negotiate to add suffixes for some of additional output columns. |
Thank you for explanations! For me the most important are the parameters of the light response curve as they can be used for further analysis. Though I do not need the quantiles of the parameters, I want to make sure that the one I want to use are not overwritten. I see that it could be difficult to implement. I add my workaround:
The output that I want is then kept in |
Hello @lsigut. |
Hello @progtw, |
The complications for this proposal for the design are one issue, but the main I repeat:
In hindsight, it might have been better also for the night-time partitioning to report only the gross fluxes with suffixes and the others outputs only for one scenario, but I do not want to change the interface now. In your workaround you demonstrate how to take care of this using the
But for your purpose, as I understood, you need only the output of a single specific uStar threshold scenario and this is now supported with the suggested PR directly. In the PR (pull request) #35 I extended the example in the vignette |
Great, thanks for the explanations, also for the vignette! |
Hi,
I am trying to do a workaround for the behaviour that is not allowing me to store all the parameters of sGLFluxPartition when run over multiple suffixes. If that is not too problematic due to the internal structure, it would be better if it can be corrected in the first place. If I use suffixes c('uStar', 'U05', 'U50', 'U95', 'UNone'), I will get some of the columns with suffixes after
sExportResults
, while some not. Some of them are identical for different runs, some of them not (PotRad, FP_Temp should not get suffixes as they are identical, also insMRFluxPartition
). Those variables without suffix will be overwritten, I will get only the results for 'UNone' and Warning message is shown:When I go through the suffix loop, resave the object and run
sGLFluxPartition
for 'uStar' suffix again I can check that content of these columns is not identical and thus should have respective suffix:Please ignore "Reco_DT_uStar_SD", "GPP_DT_uStar_SD". These are probably result of some random number generation during SD reestimation for the second time. Also the warning message is complaining about rewriting of variables with 'uStar' suffix which is correct behaviour. You can notice that warning message is also mentioning collumns that are not finally exported.
I would suggest to include suffix support for the above vector of variable names and relax the expectations for the unexported ones. I assume it will not affect the correct working of the method. Maybe you could also include suffixes in the internal collumns and get rid of
warning()
whatsoever - replacing original content with almost identical one should not cause issues.Thanks!
The text was updated successfully, but these errors were encountered: