Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHO addresses library #482

Open
sakulstra opened this issue Jun 29, 2024 · 1 comment
Open

GHO addresses library #482

sakulstra opened this issue Jun 29, 2024 · 1 comment

Comments

@sakulstra
Copy link
Collaborator

@miguelmtzinf noted that for avara it would be nice to have a GHO addresses directly accessible (not via assets library).

Putting them on Misc i was opposed, because:

  1. it's a duplication of what we already have in assets
  2. misc is used in almost every aave proposal and aave related ecosystem project. As solidity currently does not tree-shake interfaces / libraries at verification every addition bloats verification everywhere and creates noise on diffing.

That said, I think as a compromise - especially considering the growing importance of GHO - it could make sense to just create a seperate GHOMainnet, GHOArbitrum, ... and remove things like GHO, GSM, CCIP from Misc.

@eboadom
Copy link
Contributor

eboadom commented Jul 1, 2024

As the main "unit" of address book are big enough subsystems, I'd say that probably makes sense to go that way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants