Aave Funding Updates #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustboyar
reviewed
Nov 13, 2023
Zer0dot
reviewed
Nov 13, 2023
src/20231102_Multi_AaveFundingUpdates/AaveV2Ethereum_AaveFundingUpdates_20231102.t.sol
Outdated
Show resolved
Hide resolved
Zer0dot
reviewed
Nov 13, 2023
src/20231102_Multi_AaveFundingUpdates/AaveV2Ethereum_AaveFundingUpdates_20231102.t.sol
Outdated
Show resolved
Hide resolved
sakulstra
reviewed
Nov 21, 2023
sakulstra
previously approved these changes
Nov 21, 2023
|
Foundry report forge 0.2.0 (6432031 2023-11-27T00:17:02.532818051Z)Build logCompiling 264 files with 0.8.19
Solc 0.8.19 finished in 135.57s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
--> lib/aave-helpers/src/GovV3Helpers.sol:775:5:
|
775 | address votingPortal
| ^^^^^^^^^^^^^^^^^^^^
Warning (2072): Unused local variable.
--> src/20231122_AaveV3Harmony_FreezePriceFeedsOnV3Harmony/FreezePriceFeedsOnV3Harmony_20231122.s.sol:16:5:
|
16 | AaveV3Harmony_FreezePriceFeedsOnV3Harmony_20231122 payload0 = new AaveV3Harmony_FreezePriceFeedsOnV3Harmony_20231122(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| Contract | Size (kB) | Margin (kB) |
|-----------------------------------------------------------------------------------------|-----------|-------------|
| AaveGovernanceV2 | 0.086 | 24.49 |
| AaveSafetyModule | 0.086 | 24.49 |
| AaveSwapper | 5.613 | 18.963 |
| AaveV1Ethereum_FixedREPPriceFeed_20231031 | 0.706 | 23.87 |
| AaveV2Avalanche | 0.086 | 24.49 |
| AaveV2AvalancheAssets | 0.086 | 24.49 |
| AaveV2Avalanche_IncreaseStablecoinOptimalBorrowRates_20231113 | 1.899 | 22.677 |
| AaveV2Ethereum | 0.086 | 24.49 |
| AaveV2EthereumAMM | 0.086 | 24.49 |
| AaveV2EthereumAMMAssets | 0.086 | 24.49 |
| AaveV2EthereumAssets | 0.086 | 24.49 |
| AaveV2Ethereum_AaveV2EthereumLTReduction_20231030 | 3.023 | 21.553 |
| AaveV2Ethereum_Disable_Stable_Borrows_20231104 | 2.519 | 22.057 |
| AaveV2Ethereum_IncreaseStablecoinOptimalBorrowRates_20231113 | 3.078 | 21.498 |
| AaveV2Ethereum_V2DeprecationPlan20231120_20231121 | 2.003 | 22.573 |
| AaveV2Polygon | 0.086 | 24.49 |
| AaveV2PolygonAssets | 0.086 | 24.49 |
| AaveV2Polygon_AaveFundingUpdates_20231102 | 1.627 | 22.949 |
| AaveV2Polygon_IncreaseStablecoinOptimalBorrowRates_20231113 | 1.899 | 22.677 |
| AaveV2Polygon_ReserveFactorUpdatesPolygonAaveV2_20231103 | 1.01 | 23.566 |
| AaveV3Arbitrum | 0.086 | 24.49 |
| AaveV3ArbitrumAssets | 0.086 | 24.49 |
| AaveV3ArbitrumEModes | 0.086 | 24.49 |
| AaveV3Arbitrum_Disable_Stable_Borrows_20231104 | 4.14 | 20.436 |
| AaveV3Arbitrum_IncreaseStablecoinOptimalBorrowRates_20231113 | 5.167 | 19.409 |
| AaveV3Arbitrum_MAIMIMATICDeprecation20231031_20231031 | 4.227 | 20.349 |
| AaveV3Avalanche | 0.086 | 24.49 |
| AaveV3AvalancheAssets | 0.086 | 24.49 |
| AaveV3AvalancheEModes | 0.086 | 24.49 |
| AaveV3Avalanche_Disable_Stable_Borrows_20231104 | 3.471 | 21.105 |
| AaveV3Avalanche_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.665 | 19.911 |
| AaveV3Avalanche_MAIMIMATICDeprecation20231031_20231031 | 4.364 | 20.212 |
| AaveV3Base | 0.086 | 24.49 |
| AaveV3BaseAssets | 0.086 | 24.49 |
| AaveV3BaseEModes | 0.086 | 24.49 |
| AaveV3Base_IncreaseStablecoinOptimalBorrowRates_20231113 | 3.667 | 20.909 |
| AaveV3Ethereum | 0.086 | 24.49 |
| AaveV3EthereumAssets | 0.086 | 24.49 |
| AaveV3EthereumEModes | 0.086 | 24.49 |
| AaveV3Ethereum_ACIPhaseII_20231029 | 0.682 | 23.894 |
| AaveV3Ethereum_AaveFundingUpdates_20231102 | 5.809 | 18.767 |
| AaveV3Ethereum_AddFXSToEthereumV3_20231108 | 4.996 | 19.58 |
| AaveV3Ethereum_AmendSafetyModuleAAVEEmissions_20231104 | 1.938 | 22.638 |
| AaveV3Ethereum_CRVUSDOnboardingOnAaveV3Ethereum_20231116 | 4.996 | 19.58 |
| AaveV3Ethereum_ChaosLabsRiskManagementRenewal_20231101 | 1.014 | 23.562 |
| AaveV3Ethereum_ChaosLabsRiskParameterUpdatesIncreaseMKRDebtCeilingOnV3Ethereum_20231116 | 3.418 | 21.158 |
| AaveV3Ethereum_GHOIncreaseBorrowRate_20231108 | 0.326 | 24.25 |
| AaveV3Ethereum_IncreaseGHOBorrowRate_20231121 | 0.326 | 24.25 |
| AaveV3Ethereum_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.417 | 20.159 |
| AaveV3Ethereum_TokenLogicFunding_20231114 | 0.423 | 24.153 |
| AaveV3Ethereum_TreasuryManagementAddToRETHHolding_20231103 | 1.928 | 22.648 |
| AaveV3Ethereum_UpgradeAaveV3ETHPooolWETHParameters_20231031 | 3.671 | 20.905 |
| AaveV3Fantom | 0.086 | 24.49 |
| AaveV3FantomAssets | 0.086 | 24.49 |
| AaveV3FantomEModes | 0.086 | 24.49 |
| AaveV3Gnosis | 0.086 | 24.49 |
| AaveV3GnosisAssets | 0.086 | 24.49 |
| AaveV3GnosisEModes | 0.086 | 24.49 |
| AaveV3Gnosis_AaveV3GnosisActivation_20231026 | 8.802 | 15.774 |
| AaveV3Harmony | 0.086 | 24.49 |
| AaveV3HarmonyAssets | 0.086 | 24.49 |
| AaveV3HarmonyEModes | 0.086 | 24.49 |
| AaveV3Harmony_FreezePriceFeedsOnV3Harmony_20231122 | 3.097 | 21.479 |
| AaveV3Metis | 0.086 | 24.49 |
| AaveV3MetisAssets | 0.086 | 24.49 |
| AaveV3MetisEModes | 0.086 | 24.49 |
| AaveV3Metis_IncreaseStablecoinOptimalBorrowRates_20231113 | 3.914 | 20.662 |
| AaveV3Optimism | 0.086 | 24.49 |
| AaveV3OptimismAssets | 0.086 | 24.49 |
| AaveV3OptimismEModes | 0.086 | 24.49 |
| AaveV3Optimism_Disable_Stable_Borrows_20231104 | 3.851 | 20.725 |
| AaveV3Optimism_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.919 | 19.657 |
| AaveV3Optimism_MAIMIMATICDeprecation20231031_20231031 | 4.228 | 20.348 |
| AaveV3Optimism_OnboardNativeUSDCToAaveV3Optimism_20231122 | 5.551 | 19.025 |
| AaveV3Polygon | 0.086 | 24.49 |
| AaveV3PolygonAssets | 0.086 | 24.49 |
| AaveV3PolygonEModes | 0.086 | 24.49 |
| AaveV3Polygon_ChaosLabsCRVAaveV3PolygonLTReduction_20231106 | 3.416 | 21.16 |
| AaveV3Polygon_Disable_Stable_Borrows_20231104 | 4.139 | 20.437 |
| AaveV3Polygon_GauntletCapRecommendationsForPolygonV3_20231120 | 3.392 | 21.184 |
| AaveV3Polygon_GauntletRecommendationToLowerStMATICMaticXNonEmodeLTPt2_20231117 | 3.571 | 21.005 |
| AaveV3Polygon_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.416 | 20.16 |
| AaveV3Polygon_MAIMIMATICDeprecation20231031_20231031 | 4.226 | 20.35 |
| AaveV3Polygon_WMATICInterestRateUpdate_20231112 | 3.662 | 20.914 |
| Address | 0.086 | 24.49 |
| ChainHelpers | 0.086 | 24.49 |
| ChainIds | 0.086 | 24.49 |
| ConfiguratorInputTypes | 0.086 | 24.49 |
| Create2Utils | 0.164 | 24.412 |
| DataTypes | 0.086 | 24.49 |
| EngineFlags | 0.086 | 24.49 |
| Errors | 4.714 | 19.862 |
| GovHelpers | 0.086 | 24.49 |
| GovV3Helpers | 2.664 | 21.912 |
| GovV3StorageHelpers | 0.086 | 24.49 |
| GovernanceV3Arbitrum | 0.086 | 24.49 |
| GovernanceV3Avalanche | 0.086 | 24.49 |
| GovernanceV3BNB | 0.086 | 24.49 |
| GovernanceV3Base | 0.086 | 24.49 |
| GovernanceV3Ethereum | 0.086 | 24.49 |
| GovernanceV3Gnosis | 0.086 | 24.49 |
| GovernanceV3Metis | 0.086 | 24.49 |
| GovernanceV3Optimism | 0.086 | 24.49 |
| GovernanceV3Polygon | 0.086 | 24.49 |
| HelperStructs | 0.086 | 24.49 |
| IpfsUtils | 0.086 | 24.49 |
| MiscEthereum | 0.086 | 24.49 |
| MiscPolygon | 0.086 | 24.49 |
| MockExecutor | 0.437 | 24.139 |
| PayloadsControllerUtils | 0.086 | 24.49 |
| ProxyHelpers | 0.086 | 24.49 |
| ReserveConfiguration | 0.171 | 24.405 |
| SafeERC20 | 0.086 | 24.49 |
| StdStyle | 0.086 | 24.49 |
| StorageHelpers | 0.086 | 24.49 |
| WadRayMath | 0.086 | 24.49 |
| console | 0.086 | 24.49 |
| console2 | 0.086 | 24.49 |
| mock_proposal | 3.653 | 20.923 |
| safeconsole | 0.086 | 24.49 |
| stdError | 0.591 | 23.985 |
| stdJson | 0.086 | 24.49 |
| stdMath | 0.086 | 24.49 |
| stdStorage | 0.086 | 24.49 |
| stdStorageSafe | 0.086 | 24.49 |Test success 🌈No files changed, compilation skipped
Running 1 test for src/20231102_Multi_AaveFundingUpdates/AaveV2Polygon_AaveFundingUpdates_20231102.t.sol:AaveV2Polygon_AaveFundingUpdates_20231102_Test
[PASS] test_execute() (gas: 1373526)
Test result: ok. 1 passed; 0 failed; 0 skipped; finished in 57.40s
Ran 1 test suites: 1 tests passed, 0 failed, 0 skipped (1 total tests)
No files changed, compilation skipped
Running 1 test for src/20231102_Multi_AaveFundingUpdates/AaveV3Ethereum_AaveFundingUpdates_20231102.t.sol:AaveV3Ethereum_AaveFundingUpdates_20231102_Test
[PASS] test_execute() (gas: 1975541)
Test result: ok. 1 passed; 0 failed; 0 skipped; finished in 598.66s
Ran 1 test suites: 1 tests passed, 0 failed, 0 skipped (1 total tests) |
Zer0dot
previously approved these changes
Nov 22, 2023
rustboyar
previously approved these changes
Nov 22, 2023
|
@sakulstra @rustboyar @Zer0dot please never think it's too late in the review process, if my work is lacking, i totally accept that and will update until it follows best practices. |
|
@efecarranza the address-book library is generated based on what is listed on aave. |
sakulstra
reviewed
Nov 23, 2023
Zer0dot
previously approved these changes
Nov 23, 2023
Zer0dot
approved these changes
Nov 27, 2023
rustboyar
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add Ethereum mainnet proposal to deposit tokens into v3 and swap tokens for GHO.
Add Polygon proposal to bridge tokens to Ethereum mainnet.
Add tests for both proposals.
Add AIP.
Add deployment scripts.