Wrap query promise with RSVP promise #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bgentry Do you mind releasing a new version containing this? Thanks. |
|
Published v1.0.2 ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
apollo.query(...directly (nowatchQuery), if there is an error from the API that causes the promise to be rejected, the apollo service would throw an errorpromise.finally is not a function.The problem is that
querywas returning a native promise, which does not have the methodfinally, others function are wrapped with a RSVP promise but not thequery.Unfortunately, I wasn't able to reproduce the problem in the test env to be able to write a test case for this. Open to suggestions.