Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display bhr markers #66

Open
Yoric opened this issue Jan 25, 2016 · 3 comments
Open

Display bhr markers #66

Yoric opened this issue Jan 25, 2016 · 3 comments

Comments

@Yoric
Copy link

Yoric commented Jan 25, 2016

See bgirard/Gecko-Profiler-Addon#107 .
Yoric pushed a commit to Yoric/cleopatra that referenced this issue Jan 25, 2016
Resolves bgirard#66 - Display bhr markers
3349db3
@Yoric Yoric mentioned this issue Jan 25, 2016
Open
@Yoric
Copy link
Author

Yoric commented Jan 27, 2016

@bgirard ?

@bgirard
Copy link
Owner

bgirard commented Feb 1, 2016

Sorry looks like my comment never went through and then I feel sick for several days. It looks like 'includes' doesn't have wide support browser yet. If I'm not wrong then I'd rather see a more widely supported construct used.

@Yoric
Copy link
Author

Yoric commented Feb 4, 2016

@bgirard Ah, actually my comment (on Bugzilla?) didn't get through either.

My problem is that this patch actually doesn't solve the issue. Even if I instrument the code of Cleopatra, it never actually receives any data that looks like my markers from Bug 1240786.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Yoric @bgirard